Open
Conversation
rm comment
✅ Deploy Preview for tsml-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sblack4
approved these changes
Dec 25, 2025
sblack4
left a comment
sblack4
left a comment
There was a problem hiding this comment.
I tested this on mobile and am able to click already-selected items in the dropdown to un-select them. The same for web.
It seems like it fulfills the objective stated in #171 and I find the behavior pretty intuitive. Adding checkboxes like in the example (#171 (comment)) would make the behavior more obvious. We can create a seperate issue for that though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would enable multi select on mobile by allowing toggle when items are already selected, basically you can select a type, then open type dropdown again and select another. This would however change it on non mobile too, which may be unwanted and we could make this a mobile only change - or scrap this all together until other top menu items are redesigned
closes #171